Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WEBREL-3 / Kate / Test coverage: composite-calendar-mobile & calendar-icon in Reports #15561

Merged
merged 5 commits into from
Jun 13, 2024
Merged

WEBREL-3 / Kate / Test coverage: composite-calendar-mobile & calendar-icon in Reports #15561

merged 5 commits into from
Jun 13, 2024

Conversation

kate-deriv
Copy link
Contributor

@kate-deriv kate-deriv commented Jun 7, 2024 •
edited
Loading

Changes:

  • Added tests for composite-calendar-mobile & calendar-icon in Reports

Screenshots:

Screenshot 2024-06-10 at 4 09 38 PM

@vercel Vercel
Copy link

vercel bot commented Jun 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jun 10, 2024 2:40pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/15561](https://github.com/binary-com/deriv-app/pull/15561)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-webrel-3testscalendar-01a5e1.binary.sx?qa_server=red.derivws.com&app_id=32679
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-webrel-3testscalendar-01a5e1.binary.sx
- **App ID**: `32679`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-webrel-3testscalendar-01a5e1.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 43.319% (-0.001%) from 43.32%
when pulling 6304691 on kate-deriv:kate/WEBREL-3/tests_calendar_mobile_reports
into bf1fc17 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 43.531%. remained the same
when pulling 2d35f73 on kate-deriv:kate/WEBREL-3/tests_calendar_mobile_reports
into 63894c6 on binary-com:master.

@kate-deriv kate-deriv changed the title WEBREL-3 / Kate / Test coverage: composite-calendar-mobile & calendar-icon in Reports [WIP] WEBREL-3 / Kate / Test coverage: composite-calendar-mobile & calendar-icon in Reports Jun 10, 2024
@kate-deriv kate-deriv marked this pull request as ready for review June 10, 2024 13:40
@coveralls
Copy link

Coverage Status

coverage: 43.479% (-0.05%) from 43.531%
when pulling 9255956 on kate-deriv:kate/WEBREL-3/tests_calendar_mobile_reports
into 63894c6 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 43.587% (+0.06%) from 43.531%
when pulling c130949 on kate-deriv:kate/WEBREL-3/tests_calendar_mobile_reports
into 63894c6 on binary-com:master.

maryia-deriv
maryia-deriv reviewed Jun 10, 2024
View reviewed changes
...s/reports/src/Components/Form/CompositeCalendar/__tests__/composite-calendar-mobile.spec.tsx Outdated
expect(input).toHaveValue('03 Oct 2023 - 10 May 2024');
});

it('should apply date which user type in DatePicker for Start date', () => {
Copy link
Contributor

@maryia-deriv maryia-deriv Jun 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it('should apply date which user type in DatePicker for Start date', () => {
it('should apply date which user has typed in DatePicker for Start date', () => {

nit-pick) same for the next test case)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, will correct mistake)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Coverage Status

coverage: 43.587% (+0.06%) from 43.531%
when pulling 669eb67 on kate-deriv:kate/WEBREL-3/tests_calendar_mobile_reports
into 63894c6 on binary-com:master.

@balakrishna-deriv balakrishna-deriv merged commit 8e2e29d into binary-com:master Jun 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balakrishna-deriv balakrishna-deriv balakrishna-deriv approved these changes

@maryia-deriv maryia-deriv maryia-deriv approved these changes

@henry-deriv henry-deriv henry-deriv approved these changes

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kate-deriv @coveralls @balakrishna-deriv @maryia-deriv @henry-deriv